packages/ui/src/components/UserProfile/__tests__/ConnectedAccountsSection.test.tsx (1)

140-177: ⚡ Quick win

Add a transport reconnect test for the new ConnectedAccount.reconnect path.

The added transport coverage only exercises the add-connection menu. The reconnect flow now has separate transport behavior (getRedirectUrl, reauthorize vs createExternalAccount, open, user.reload), but none of that is asserted in this suite yet.

As per coding guidelines, **/*.{test,spec}.{ts,tsx}: Unit tests are required for all new functionality.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@packages/ui/src/components/UserProfile/__tests__/ConnectedAccountsSection.test.tsx`
around lines 140 - 177, Add a unit test in ConnectedAccountsSection.test.tsx
that covers the new reconnect path on ConnectedAccount.reconnect: set up a
fixture with an existing external account, register a mock
__internal_oauthTransport that implements getRedirectUrl and reauthorize
(mockResolvedValue), render the component and trigger theReconnect UI action
(click the reconnect button), then assert that
transport.getRedirectUrl/reauthorize were called with the expected URL/params,
that user.reload was called, and that the add-connection flow helpers
(createExternalAccount/open) were not invoked for this reconnect path; reference
the test helpers/objects fixtures.clerk,
fixtures.clerk.__internal_oauthTransport, ConnectedAccount.reconnect, and
fixtures.clerk.user!.reload when implementing the assertions.

Source: Coding guidelines

packages/clerk-js/src/core/resources/__tests__/SignUp.test.ts (1)

38-79: ⚡ Quick win

Consider additional test coverage for transport behavior.

The test validates the happy path but could be more comprehensive:

1. Missing assertion: The test name claims the transport routes "instead of windowNavigate," but there's no assertion verifying that windowNavigate (or similar browser redirect mechanisms) is NOT called. Consider adding a spy to verify the normal redirect path is bypassed.

2. Error handling: No coverage for what happens when transport.open rejects or when handleResourceCallback fails. These paths should be tested to ensure proper error propagation.

3. Backwards compatibility: Consider adding a test case where no transport is registered to verify the existing redirect behavior still works (regression protection).

📋 Suggested additional test cases

it('falls back to normal redirect when no transport is registered', async () => {
  const mockNavigate = vi.fn();
  SignUp.clerk = {
    buildUrlWithAuth: vi.fn(u => u),
    // No __internal_oauthTransport
    __internal_environment: { displayConfig: { captchaOauthBypass: [] } },
  } as any;
  
  // Mock windowNavigate or similar
  const navigateSpy = vi.spyOn(window, 'location', 'set');
  
  const mockFetch = vi.fn().mockResolvedValueOnce({
    client: null,
    response: {
      id: 'signup_123',
      verifications: {
        external_account: {
          status: 'unverified',
          external_verification_redirect_url: 'https://provider.example/auth',
        },
      },
    },
  });
  BaseResource._fetch = mockFetch;
  
  const signUp = new SignUp();
  await signUp.authenticateWithRedirect({
    strategy: 'oauth_google',
    redirectUrl: '/sso-callback',
    redirectUrlComplete: '/',
  } as any);
  
  // Verify normal redirect occurred
  expect(navigateSpy).toHaveBeenCalled();
});

it('handles transport rejection gracefully', async () => {
  const open = vi.fn().mockRejectedValue(new Error('Transport unavailable'));
  SignUp.clerk = {
    buildUrlWithAuth: vi.fn(u => u),
    __internal_oauthTransport: { getRedirectUrl: () => 'myapp://sso-callback', open },
    __internal_handleResourceCallback: vi.fn(),
    __internal_environment: { displayConfig: { captchaOauthBypass: [] } },
  } as any;
  
  const mockFetch = vi.fn().mockResolvedValueOnce({
    client: null,
    response: {
      id: 'signup_123',
      verifications: {
        external_account: {
          status: 'unverified',
          external_verification_redirect_url: 'https://provider.example/auth',
        },
      },
    },
  });
  BaseResource._fetch = mockFetch;
  
  const signUp = new SignUp();
  
  await expect(
    signUp.authenticateWithRedirect({
      strategy: 'oauth_google',
      redirectUrl: '/sso-callback',
      redirectUrlComplete: '/',
      __internal_callbackParams: { signInUrl: '/sign-in' },
    } as any)
  ).rejects.toThrow('Transport unavailable');
});

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/clerk-js/src/core/resources/__tests__/SignUp.test.ts` around lines
38 - 79, Test currently only asserts the happy path through the OAuth transport
(SignUp.authenticateWithRedirect using
SignUp.clerk.__internal_oauthTransport.open) but misses verifying the normal
browser redirect is not invoked and lacks failure/back-compat cases; add three
tests: (1) spy on the browser navigation mechanism (e.g., spyOn(window,
'location', 'set') or the project's windowNavigate helper) and assert it is NOT
called when __internal_oauthTransport is present, (2) a test where
__internal_oauthTransport.open rejects and assert authenticateWithRedirect
rejects with that error (and that __internal_handleResourceCallback is not
called), and (3) a fallback test with no __internal_oauthTransport registered
that asserts the code falls back to the normal redirect path (using
BaseResource._fetch to return the external_verification_redirect_url and
verifying the window navigation spy was called).

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes